Upgrade the urbanairship-react-native package #3508
Conversation
MelvinBot
requested review from
HorusGoul and
TomatoToaster
and removed request for
a team
There was a problem hiding this comment.
Tests well for me on iOS simulator and Android emulator. I noticed that we seem to get stuck when logging back in after logging out. But a refresh resolves this and [this was not introduced by this PR](Endless loading spinner appears when re login
).
(I'm reviewing as we need to unblock deployBlockers for our N5 build)
|
Removing @sketchydroide as he's off today. Would one of the remaining reviewers be able to review this today? It's one of a few issues blocking the N5 build deployment. |
|
Thanks Amal!!! |
|
🚀 Deployed to staging in version: 1.0.66-13🚀
|
Android - Notification not received if app is backgroundedExpected Result:User receives push notification Actual Result:No push notification received Actions Performed:
Platform:Android ✔️ Build:1.0.67-0 Notes/Images/Video:Bug5107452_screen-20210610-194541.mp4 |
|
The above issue has been moved to it's own issue: #3542 (comment) |
|
Checking the PR off the checklist since the bug will be addressed on a different issue. |
|
🚀 Deployed to production in version: 1.0.68-4🚀
|
Details
This PR updates the urbanairship-react-native package to fix an issue where removing all listeners (PushNotification.deregister) throws an error in the old package.
Fixed Issues
Fixes #3503
Tests
While testing this, I noticed that the TestFlight build sent push notifications properly, but when building to a physical device (iOS since I don't have an Android) the push notifications never came through. I confirmed that the same behavior happens when building to my device using the same version that is on the TestFlight (where pushes are working fine), so this may have to be fully confirmed when the build is on the TF. cc @roryabraham and @sketchydroide to confirm since you both have tested this before.
QA Steps
On the testflight build, sign into an account on iOS and Android then background the app. On another account, send a message to that account and confirm you receive a push notification.
Tested On